From: Noel Power <noel.power@suse.com>
Date: Thu, 10 Jun 2021 13:11:03 +0000 (+0100)
Subject: s3/smbd: Remove unecessary 'else' block
X-Git-Tag: tevent-0.11.0~387
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=0f5c6c0aa01245276d8d399269576f5296e00f36;p=thirdparty%2Fsamba.git

s3/smbd: Remove unecessary 'else' block

This is an inconsequential cosmetic change, it just caught my eye
as looking a bit out of place compared to the surrounding code style.

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source3/smbd/open.c b/source3/smbd/open.c
index 101757666fe..785a445e5cf 100644
--- a/source3/smbd/open.c
+++ b/source3/smbd/open.c
@@ -3613,9 +3613,8 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
 					 smb_fname_str_dbg(smb_fname)));
 				if (S_ISDIR(smb_fname->st.st_ex_mode)) {
 					return NT_STATUS_FILE_IS_A_DIRECTORY;
-				} else {
-					return NT_STATUS_OBJECT_NAME_COLLISION;
 				}
+				return NT_STATUS_OBJECT_NAME_COLLISION;
 			}
 			break;