From: Simon McVittie Date: Tue, 12 Dec 2017 14:05:20 +0000 (+0000) Subject: tests: Assert that dbus-daemon filters unknown header fields X-Git-Tag: dbus-1.13.0~33 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=0fb9eaa3d4ddeb0ee779029a379417bf813670f1;p=thirdparty%2Fdbus.git tests: Assert that dbus-daemon filters unknown header fields Bug: https://bugs.freedesktop.org/show_bug.cgi?id=100317 Reviewed-by: Philip Withnall Signed-off-by: Simon McVittie --- diff --git a/test/dbus-daemon.c b/test/dbus-daemon.c index 9305866b8..7f990a7e6 100644 --- a/test/dbus-daemon.c +++ b/test/dbus-daemon.c @@ -1594,6 +1594,7 @@ check_features (DBusMessageIter *var_iter) { DBusMessageIter arr_iter; gboolean have_systemd_activation = FALSE; + gboolean have_header_filtering = FALSE; g_assert_cmpint (dbus_message_iter_get_arg_type (var_iter), ==, DBUS_TYPE_ARRAY); @@ -1611,12 +1612,15 @@ check_features (DBusMessageIter *var_iter) g_test_message ("Feature: %s", feature); - if (g_strcmp0 (feature, "SystemdActivation") == 0) + if (g_strcmp0 (feature, "HeaderFiltering") == 0) + have_header_filtering = TRUE; + else if (g_strcmp0 (feature, "SystemdActivation") == 0) have_systemd_activation = TRUE; dbus_message_iter_next (&arr_iter); } + g_assert_true (have_header_filtering); /* We pass --systemd-activation to the daemon for this unit test on Unix * (it can only work in practice on Linux, but there's nothing * inherently Linux-specific about the protocol). */ diff --git a/test/header-fields.c b/test/header-fields.c index 09b4f99c4..ad7ceac53 100644 --- a/test/header-fields.c +++ b/test/header-fields.c @@ -625,10 +625,7 @@ test_weird_header_field (void *user_data, ==, DBUS_TYPE_BYTE); _dbus_type_reader_read_basic (&sub, &field_code); - if (field_code == NOT_A_HEADER_FIELD) - { - g_test_message ("TODO: header field was passed through"); - } + g_assert_cmpuint (field_code, !=, NOT_A_HEADER_FIELD); _dbus_type_reader_next (&array); }