From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Date: Mon, 3 Oct 2022 04:02:46 +0000 (-0700)
Subject: gh-97740: Fix bang in Sphinx C domain ref target syntax (GH-97741)
X-Git-Tag: v3.11.0~71
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=10818aa83302b30e79eeb4ffb1bbafa1c4e0d066;p=thirdparty%2FPython%2Fcpython.git

gh-97740: Fix bang in Sphinx C domain ref target syntax (GH-97741)


* gh-97740: Fix bang in Sphinx C domain ref target syntax

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

* Add NEWS entry for C domain bang fix

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
(cherry picked from commit 9148c0d893c7807331fd7be0997261e289074bc5)

Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
---

diff --git a/Doc/conf.py b/Doc/conf.py
index fd4ee2d5eee8..e5c989da0b36 100644
--- a/Doc/conf.py
+++ b/Doc/conf.py
@@ -234,3 +234,28 @@ linkcheck_ignore = [r'https://bugs.python.org/(issue)?\d+']
 # Relative filename of the data files
 refcount_file = 'data/refcounts.dat'
 stable_abi_file = 'data/stable_abi.dat'
+
+# Sphinx 2 and Sphinx 3 compatibility
+# -----------------------------------
+
+# bpo-40204: Allow Sphinx 2 syntax in the C domain
+c_allow_pre_v3 = True
+
+# bpo-40204: Disable warnings on Sphinx 2 syntax of the C domain since the
+# documentation is built with -W (warnings treated as errors).
+c_warn_on_allowed_pre_v3 = False
+
+# Fix '!' not working with C domain when pre_v3 is enabled
+import sphinx
+
+if sphinx.version_info[:2] < (5, 3):
+    from sphinx.domains.c import CXRefRole
+
+    original_run = CXRefRole.run
+
+    def new_run(self):
+        if self.disabled:
+            return super(CXRefRole, self).run()
+        return original_run(self)
+
+    CXRefRole.run = new_run
diff --git a/Misc/NEWS.d/next/Documentation/2022-10-02-10-58-52.gh-issue-97741.39l023.rst b/Misc/NEWS.d/next/Documentation/2022-10-02-10-58-52.gh-issue-97741.39l023.rst
new file mode 100644
index 000000000000..8da9c92f6fd8
--- /dev/null
+++ b/Misc/NEWS.d/next/Documentation/2022-10-02-10-58-52.gh-issue-97741.39l023.rst
@@ -0,0 +1,2 @@
+Fix ``!`` in c domain ref target syntax via a ``conf.py`` patch, so it works
+as intended to disable ref target resolution.