From: Günther Deschner <gd@samba.org>
Date: Tue, 4 Mar 2008 11:46:15 +0000 (+0100)
Subject: Fix lsa_QueryInfoPolicy: make proper talloc copies of the sids.
X-Git-Tag: samba-3.2.0pre2~5
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=1081da4d83dbfb6d87c3267c5e00e668b2151294;p=thirdparty%2Fsamba.git

Fix lsa_QueryInfoPolicy: make proper talloc copies of the sids.

Guenther
(cherry picked from commit b9441232d66d78e66464be6c9748a023681ce6ca)
---

diff --git a/source/rpc_server/srv_lsa_nt.c b/source/rpc_server/srv_lsa_nt.c
index c2502141e54..c03630d6f9e 100644
--- a/source/rpc_server/srv_lsa_nt.c
+++ b/source/rpc_server/srv_lsa_nt.c
@@ -603,15 +603,22 @@ NTSTATUS _lsa_QueryInfoPolicy(pipes_struct *p,
 			case ROLE_DOMAIN_PDC:
 			case ROLE_DOMAIN_BDC:
 				name = get_global_sam_name();
-				sid = get_global_sam_sid();
+				sid = sid_dup_talloc(p->mem_ctx, get_global_sam_sid());
+				if (!sid) {
+					return NT_STATUS_NO_MEMORY;
+				}
 				break;
 			case ROLE_DOMAIN_MEMBER:
 				name = lp_workgroup();
 				/* We need to return the Domain SID here. */
-				if (secrets_fetch_domain_sid(lp_workgroup(), &domain_sid))
-					sid = &domain_sid;
-				else
+				if (secrets_fetch_domain_sid(lp_workgroup(), &domain_sid)) {
+					sid = sid_dup_talloc(p->mem_ctx, &domain_sid);
+					if (!sid) {
+						return NT_STATUS_NO_MEMORY;
+					}
+				} else {
 					return NT_STATUS_CANT_ACCESS_DOMAIN_INFO;
+				}
 				break;
 			case ROLE_STANDALONE:
 				name = lp_workgroup();