From: Frantisek Sumsal <frantisek@sumsal.cz>
Date: Sat, 2 May 2020 13:18:35 +0000 (+0200)
Subject: test: fix potential use-after-free
X-Git-Tag: v246-rc1~456
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=111e71c431bae9c69a7e1ed7e192fc58ad2e3c53;p=thirdparty%2Fsystemd.git

test: fix potential use-after-free

CID#1428676.
---

diff --git a/src/test/test-cgroup-util.c b/src/test/test-cgroup-util.c
index 5826d6ec283..ea47f5affab 100644
--- a/src/test/test-cgroup-util.c
+++ b/src/test/test-cgroup-util.c
@@ -388,7 +388,7 @@ static void test_cg_get_keyed_attribute(void) {
         assert_se(val == NULL);
 
         assert_se(cg_get_keyed_attribute("cpu", "/init.scope", "cpu.stat", STRV_MAKE("usage_usec"), &val) == 0);
-        free(val);
+        val = mfree(val);
 
         assert_se(cg_get_keyed_attribute_graceful("cpu", "/init.scope", "cpu.stat", STRV_MAKE("usage_usec"), &val) == 1);
         log_info("cpu /init.scope cpu.stat [usage_usec] → \"%s\"", val);