From: Matthijs Mekking <matthijs@isc.org>
Date: Wed, 18 Aug 2021 13:57:03 +0000 (+0200)
Subject: Change "receive_secure_serial: unchanged" log lvl
X-Git-Tag: v9.17.18~26^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=1127b1f3eb07a418f39886c9825805fc369f4196;p=thirdparty%2Fbind9.git

Change "receive_secure_serial: unchanged" log lvl

After a reload, if the zone hasn't changed, this will log a
DNS_R_UNCHANGED error. This should not be at error level because it
happens on every reload.
---

diff --git a/lib/dns/zone.c b/lib/dns/zone.c
index e97202b30b0..77432951ebd 100644
--- a/lib/dns/zone.c
+++ b/lib/dns/zone.c
@@ -16573,7 +16573,6 @@ nextevent:
 					     start, end, &soatuple,
 					     &zone->rss_diff);
 		if (result == DNS_R_UNCHANGED) {
-			level = ISC_LOG_INFO;
 			goto failure;
 		} else if (result != ISC_R_SUCCESS) {
 			CHECK(sync_secure_db(zone, zone->rss_raw, zone->rss_db,
@@ -16681,6 +16680,9 @@ failure:
 		TIME_NOW(&timenow);
 		zone_settimer(zone, &timenow);
 		UNLOCK_ZONE(zone);
+		if (result == DNS_R_UNCHANGED) {
+			level = ISC_LOG_INFO;
+		}
 		dns_zone_log(zone, level, "receive_secure_serial: %s",
 			     dns_result_totext(result));
 	}