From: Theodore Ts'o Date: Mon, 6 Aug 2012 03:28:16 +0000 (-0400) Subject: ext4: avoid kmemcheck complaint from reading uninitialized memory X-Git-Tag: v3.2.29~87 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=11306f0a62f8c12b0fa4a35d0b4dc5a91fa79612;p=thirdparty%2Fkernel%2Fstable.git ext4: avoid kmemcheck complaint from reading uninitialized memory commit 7e731bc9a12339f344cddf82166b82633d99dd86 upstream. Commit 03179fe923 introduced a kmemcheck complaint in ext4_da_get_block_prep() because we save and restore ei->i_da_metadata_calc_last_lblock even though it is left uninitialized in the case where i_da_metadata_calc_len is zero. This doesn't hurt anything, but silencing the kmemcheck complaint makes it easier for people to find real bugs. Addresses https://bugzilla.kernel.org/show_bug.cgi?id=45631 (which is marked as a regression). Signed-off-by: "Theodore Ts'o" Signed-off-by: Ben Hutchings --- diff --git a/fs/ext4/super.c b/fs/ext4/super.c index a071348c9efb8..129925ad90d10 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -904,6 +904,7 @@ static struct inode *ext4_alloc_inode(struct super_block *sb) ei->i_reserved_meta_blocks = 0; ei->i_allocated_meta_blocks = 0; ei->i_da_metadata_calc_len = 0; + ei->i_da_metadata_calc_last_lblock = 0; spin_lock_init(&(ei->i_block_reservation_lock)); #ifdef CONFIG_QUOTA ei->i_reserved_quota = 0;