From: Antoine Pitrou <solipsis@pitrou.net>
Date: Wed, 23 Nov 2011 00:39:19 +0000 (+0100)
Subject: Issue #13458: Fix a memory leak in the ssl module when decoding a certificate with... 
X-Git-Tag: v3.2.3rc1~366
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=116d6b98bf9c09760269db093f3251a16b6c1e81;p=thirdparty%2FPython%2Fcpython.git

Issue #13458: Fix a memory leak in the ssl module when decoding a certificate with a subjectAltName.
Patch by Robert Xiao.
---

diff --git a/Misc/NEWS b/Misc/NEWS
index 635081827508..f65fafe2eaff 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -83,6 +83,9 @@ Core and Builtins
 Library
 -------
 
+- Issue #13458: Fix a memory leak in the ssl module when decoding a
+  certificate with a subjectAltName.  Patch by Robert Xiao.
+
 - Issue #13415: os.unsetenv() doesn't ignore errors anymore.
 
 - Issue #13322: Fix BufferedWriter.write() to ensure that BlockingIOError is
diff --git a/Modules/_ssl.c b/Modules/_ssl.c
index 84ec477aaa95..5419059e2998 100644
--- a/Modules/_ssl.c
+++ b/Modules/_ssl.c
@@ -679,6 +679,7 @@ _get_peer_alt_names (X509 *certificate) {
             }
             Py_DECREF(t);
         }
+        sk_GENERAL_NAME_pop_free(names, GENERAL_NAME_free);
     }
     BIO_free(biobuf);
     if (peer_alt_names != Py_None) {