From: Nicolas Schier <n.schier@avm.de>
Date: Tue, 18 Apr 2023 08:52:38 +0000 (+0200)
Subject: modprobe: rmmod_do_module: Free kmod list of holders
X-Git-Tag: v31~10
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=116e7c7fc00e8565caf913399c38852975094a75;p=thirdparty%2Fkmod.git

modprobe: rmmod_do_module: Free kmod list of holders

Add a missing kmod_module_unref_list() to fix a memory leak.

Fixes: 42b32d30c38e ("modprobe: Fix holders removal")
Signed-off-by: Nicolas Schier <n.schier@avm.de>
Signed-off-by: Lucas De Marchi <lucas.de.marchi@gmail.com>
---

diff --git a/tools/modprobe.c b/tools/modprobe.c
index 3b7897c1..e8910283 100644
--- a/tools/modprobe.c
+++ b/tools/modprobe.c
@@ -455,6 +455,7 @@ static int rmmod_do_module(struct kmod_module *mod, int flags)
 		struct kmod_list *holders = kmod_module_get_holders(mod);
 
 		err = rmmod_do_modlist(holders, true);
+		kmod_module_unref_list(holders);
 		if (err < 0)
 			goto error;
 	}