From: Phạm Bình An <phambinhanctb2004@gmail.com>
Date: Tue, 18 Mar 2025 20:05:35 +0000 (+0100)
Subject: runtime(go): use :term for keywordprg for nvim/gvim
X-Git-Tag: v9.1.1224~1
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=11ab02c819449eaeddc3d8d291f06bc73f428e91;p=thirdparty%2Fvim.git

runtime(go): use :term for keywordprg for nvim/gvim

Problem:
- The document from `go doc` can be very long, and you can scroll if
  using `!` to run shell command in Gvim.
- I realize that I didn't fully mimic behavior of default keywordprg
  in Nvim in the last commit.

Solution:
- Use builtin terminal for keywordprg in Gvim
- In Nvim (both TUI and GUI), it should mimic the behavior of Vim
  `:term`, `:Man`, and `:help`

closes: #16911

Co-authored-by: zeertzjq <zeertzjq@outlook.com>
Signed-off-by: Phạm Bình An <phambinhanctb2004@gmail.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
---

diff --git a/runtime/ftplugin/go.vim b/runtime/ftplugin/go.vim
index b83db424bd..57fc73cd13 100644
--- a/runtime/ftplugin/go.vim
+++ b/runtime/ftplugin/go.vim
@@ -1,9 +1,10 @@
 " Vim filetype plugin file
 " Language:	Go
-" Maintainer:	David Barnett (https://github.com/google/vim-ft-go)
+" Maintainer:	David Barnett (https://github.com/google/vim-ft-go is archived)
 " Last Change:	2014 Aug 16
 " 2024 Jul 16 by Vim Project (add recommended indent style)
 " 2025 Mar 07 by Vim Project (add formatprg and keywordprg option #16804)
+" 2025 Mar 18 by Vim Project (use :term for 'keywordprg' #16911)
 
 if exists('b:did_ftplugin')
   finish
@@ -33,10 +34,8 @@ if !exists('*' .. expand('<SID>') .. 'GoKeywordPrg')
     setl iskeyword+=.
     try
       let cmd = 'go doc -C ' . shellescape(expand('%:h')) . ' ' . shellescape(expand('<cword>'))
-      if has('nvim')
-        exe "term" cmd
-        startinsert
-        tmap <buffer> <Esc> <Cmd>call jobstop(&channel) <Bar> bdelete<CR>
+      if has('gui_running') || has('nvim')
+        exe 'hor term' cmd
       else
         exe '!' . cmd
       endif