From: Matt Fleming Date: Sun, 2 Nov 2008 16:04:18 +0000 (+0000) Subject: x86: HPET: convert WARN_ON to WARN_ON_ONCE X-Git-Tag: v2.6.27.9~20 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=11ab6487b5c44b37faaa0d01ad362d5afa4f3570;p=thirdparty%2Fkernel%2Fstable.git x86: HPET: convert WARN_ON to WARN_ON_ONCE commit 1de5b0854623d30d01d72cd4ea323eb5f39d1f16 upstream. It is possible to flood the console with call traces if the WARN_ON condition is true because of the frequency with which this function is called. Signed-off-by: Matt Fleming Cc: mingo@elte.hu Cc: venkatesh.pallipadi@intel.com Signed-off-by: Thomas Gleixner Cc: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- diff --git a/arch/x86/kernel/hpet.c b/arch/x86/kernel/hpet.c index 73deaffadd036..759e8da4ed3ab 100644 --- a/arch/x86/kernel/hpet.c +++ b/arch/x86/kernel/hpet.c @@ -283,7 +283,7 @@ static int hpet_legacy_next_event(unsigned long delta, * what we wrote hit the chip before we compare it to the * counter. */ - WARN_ON((u32)hpet_readl(HPET_T0_CMP) != cnt); + WARN_ON_ONCE((u32)hpet_readl(HPET_T0_CMP) != cnt); return (s32)((u32)hpet_readl(HPET_COUNTER) - cnt) >= 0 ? -ETIME : 0; }