From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Date: Wed, 21 May 2025 19:35:31 +0000 (+0200)
Subject: [3.14] gh-132983: Fix refleak in zstd dictionary functions (gh-134463)
X-Git-Tag: v3.14.0b2~61
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=11d77d21120b77ddfd97f471c0d7a31745141131;p=thirdparty%2FPython%2Fcpython.git

[3.14] gh-132983: Fix refleak in zstd dictionary functions (gh-134463)

(cherry picked from commit fb68776591485, AKA gh-134459)

Co-authored-by: Emma Smith <emma@emmatyping.dev>
---

diff --git a/Modules/_zstd/_zstdmodule.c b/Modules/_zstd/_zstdmodule.c
index b2e4f95b9063..17d3bff1e987 100644
--- a/Modules/_zstd/_zstdmodule.c
+++ b/Modules/_zstd/_zstdmodule.c
@@ -251,7 +251,7 @@ _zstd_train_dict_impl(PyObject *module, PyBytesObject *samples_bytes,
                                             &chunk_sizes);
     if (chunks_number < 0)
     {
-        return NULL;
+        goto error;
     }
 
     /* Allocate dict buffer */
@@ -333,7 +333,7 @@ _zstd_finalize_dict_impl(PyObject *module, PyBytesObject *custom_dict_bytes,
                                             &chunk_sizes);
     if (chunks_number < 0)
     {
-        return NULL;
+        goto error;
     }
 
     /* Allocate dict buffer */