From: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
Date: Thu, 3 Nov 2022 14:29:11 +0000 (-0700)
Subject: gh-83004: Clean up refleak in _io initialisation (#98840)
X-Git-Tag: v3.12.0a2~145
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=1208037246eeab4c5c003f1651edfefb045e6fb7;p=thirdparty%2FPython%2Fcpython.git

gh-83004: Clean up refleak in _io initialisation (#98840)
---

diff --git a/Misc/NEWS.d/next/Library/2022-11-02-05-52-36.gh-issue-83004.LBl79O.rst b/Misc/NEWS.d/next/Library/2022-11-02-05-52-36.gh-issue-83004.LBl79O.rst
new file mode 100644
index 000000000000..4de17abd0634
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2022-11-02-05-52-36.gh-issue-83004.LBl79O.rst
@@ -0,0 +1 @@
+Clean up refleak on failed module initialisation in :mod:`_io`.
diff --git a/Modules/_io/_iomodule.c b/Modules/_io/_iomodule.c
index 38ef24637b73..a7b2e984310d 100644
--- a/Modules/_io/_iomodule.c
+++ b/Modules/_io/_iomodule.c
@@ -703,10 +703,10 @@ PyInit__io(void)
         goto fail;
 
     /* BlockingIOError, for compatibility */
-    Py_INCREF(PyExc_BlockingIOError);
-    if (PyModule_AddObject(m, "BlockingIOError",
-                           (PyObject *) PyExc_BlockingIOError) < 0)
+    if (PyModule_AddObjectRef(m, "BlockingIOError",
+                              (PyObject *) PyExc_BlockingIOError) < 0) {
         goto fail;
+    }
 
     // Set type base classes
     PyFileIO_Type.tp_base = &PyRawIOBase_Type;