From: Nick Mathewson <nickm@torproject.org>
Date: Fri, 2 Dec 2016 12:39:14 +0000 (-0500)
Subject: test_single_onion_poisoning: Free dir[12] on all paths
X-Git-Tag: tor-0.2.9.6-rc~2^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=1221c5aa02c0a9789de92d16935cf74da5365822;p=thirdparty%2Ftor.git

test_single_onion_poisoning: Free dir[12] on all paths

Coverity doesn't like it when there are paths to the end of the
function where something doesn't get freed, even when those paths
are only reachable on unit test failure.

Fixes CID 1372899 and CID 1372900. Bug not in any released Tor.
---

diff --git a/src/test/test_hs.c b/src/test/test_hs.c
index fc8ce97852..f4ba7f9e0e 100644
--- a/src/test/test_hs.c
+++ b/src/test/test_hs.c
@@ -765,6 +765,8 @@ test_single_onion_poisoning(void *arg)
   tt_assert(ret == 0);
 
  done:
+  tor_free(dir1);
+  tor_free(dir2);
   /* The test harness deletes the directories at exit */
   smartlist_free(services);
   rend_service_free(service_1);