From: Tom Krizek <tkrizek@isc.org>
Date: Wed, 10 Jan 2024 09:53:18 +0000 (+0100)
Subject: Allow nsupdate test rerun on FreeBSD
X-Git-Tag: v9.19.22~90^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=124882476b31a22daea84af54fbed9a83e5d5b6e;p=thirdparty%2Fbind9.git

Allow nsupdate test rerun on FreeBSD

The "exceeded time limit waiting for literal 'too many DNS UPDATEs
queued' in ns1/named.run" is prone to fail due to a timing issue.
Despite out efforts to stabilize it, the check still often fails on
FreeBSD in our CI. Allow the test to be re-run on this platform.
---

diff --git a/bin/tests/system/nsupdate/tests_sh_nsupdate.py b/bin/tests/system/nsupdate/tests_sh_nsupdate.py
index 897eb083169..5c1a9c7e3de 100644
--- a/bin/tests/system/nsupdate/tests_sh_nsupdate.py
+++ b/bin/tests/system/nsupdate/tests_sh_nsupdate.py
@@ -9,6 +9,14 @@
 # See the COPYRIGHT file distributed with this work for additional
 # information regarding copyright ownership.
 
+import platform
 
+import pytest_custom_markers
+
+
+MAX_RUNS = 2 if platform.system() == "FreeBSD" else 1  # GL#3846
+
+
+@pytest_custom_markers.flaky(max_runs=MAX_RUNS)
 def test_nsupdate(run_tests_sh):
     run_tests_sh()