From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Date: Sun, 18 Dec 2016 20:47:41 +0000 (-0500)
Subject: build-sys: treat format errors as fatal (#4910)
X-Git-Tag: v233~307
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=12d6389c14816811c2418062b914b36a8a27ef5d;p=thirdparty%2Fsystemd.git

build-sys: treat format errors as fatal (#4910)

We currently don't expect any warnings about format strings, on any
architecture (#4612 removed the last few warnings). Turn those warnings into
errors in the future.

As requested by Martin Pitt.

gcc documentation says that -Wformat=2 includes -Wformat-security and
-Wformat-nonliteral so don't include them explicitly.
---

diff --git a/configure.ac b/configure.ac
index 4a05702094b..a071bfa69e7 100644
--- a/configure.ac
+++ b/configure.ac
@@ -155,7 +155,6 @@ CC_CHECK_FLAGS_APPEND([with_cflags], [CFLAGS], [\
         -Wall \
         -Wextra \
         -Wundef \
-        "-Wformat=2 -Wformat-security -Wformat-nonliteral" \
         -Wlogical-op \
         -Wmissing-include-dirs \
         -Wold-style-definition \
@@ -168,6 +167,7 @@ CC_CHECK_FLAGS_APPEND([with_cflags], [CFLAGS], [\
         -Werror=implicit-function-declaration \
         -Werror=missing-declarations \
         -Werror=return-type \
+        -Werror=format=2 \
         -Wstrict-prototypes \
         -Wredundant-decls \
         -Wmissing-noreturn \