From: Pablo Galindo <Pablogsal@gmail.com>
Date: Mon, 27 Jul 2020 22:46:59 +0000 (+0100)
Subject: Validate the AST produced by the parser in debug mode (GH-21643)
X-Git-Tag: v3.10.0a1~335
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=1332226b32da44087a55e1d71990ee6899dfd28a;p=thirdparty%2FPython%2Fcpython.git

Validate the AST produced by the parser in debug mode (GH-21643)

This will improve the debug experience if something fails in the produced AST. Previously, errors in the produced AST can be felt much later like in the garbage collector or the compiler, making debugging them much more difficult.
---

diff --git a/Parser/pegen.c b/Parser/pegen.c
index e2cbf8ba2461..f615907f5f57 100644
--- a/Parser/pegen.c
+++ b/Parser/pegen.c
@@ -4,6 +4,7 @@
 
 #include "pegen.h"
 #include "string_parser.h"
+#include "ast.h"
 
 PyObject *
 _PyPegen_new_type_comment(Parser *p, char *s)
@@ -1137,6 +1138,14 @@ _PyPegen_run_parser(Parser *p)
         return RAISE_SYNTAX_ERROR("multiple statements found while compiling a single statement");
     }
 
+#if defined(Py_DEBUG) && defined(Py_BUILD_CORE)
+    if (p->start_rule == Py_single_input ||
+        p->start_rule == Py_file_input ||
+        p->start_rule == Py_eval_input)
+    {
+        assert(PyAST_Validate(res));
+    }
+#endif
     return res;
 }