From: Takashi Sakamoto Date: Thu, 11 Sep 2025 22:13:11 +0000 (+0900) Subject: firewire: core: remove useless lockdep_assert_held() X-Git-Tag: v6.18-rc1~159^2~24 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=136d8a6f73fee0686d163dca91fdffb35e25f092;p=thirdparty%2Flinux.git firewire: core: remove useless lockdep_assert_held() The bm_work work item should be scheduled after holding fw_card reference counting. At a commit 25feb1a96e21 ("firewire: core: use cleanup function in bm_work"), I misinterpreted it as fw_card spinlock and inserted lockdep_assert_hold() wrongly. This commit removes the useless line. Fixes: 25feb1a96e21 ("firewire: core: use cleanup function in bm_work") Link: https://lore.kernel.org/r/20250911221312.678076-1-o-takashi@sakamocchi.jp Signed-off-by: Takashi Sakamoto --- diff --git a/drivers/firewire/core-card.c b/drivers/firewire/core-card.c index 474d8066e090b..32cf6b3344cd9 100644 --- a/drivers/firewire/core-card.c +++ b/drivers/firewire/core-card.c @@ -294,8 +294,6 @@ static void bm_work(struct work_struct *work) int expected_gap_count, generation, grace; bool do_reset = false; - lockdep_assert_held(&card->lock); - spin_lock_irq(&card->lock); if (card->local_node == NULL) {