From: Glenn Washburn Date: Thu, 11 Aug 2022 17:48:42 +0000 (-0500) Subject: misc: Add cast in grub_strncasecmp() to drop sign when calling grub_tolower() X-Git-Tag: grub-2.12-rc1~289 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=13fb5af10c835c32862e6c861fc655101e2917c7;p=thirdparty%2Fgrub.git misc: Add cast in grub_strncasecmp() to drop sign when calling grub_tolower() Note this cast was fixed in grub_strcasecmp() in commit ce41ab7aab (* grub-core/kern/misc.c (grub_strcmp): Use unsigned comparison as per common usage and preffered in several parts of code.), but this commit omitted fixing it in grub_strncasecmp(). Signed-off-by: Glenn Washburn Reviewed-by: Daniel Kiper --- diff --git a/include/grub/misc.h b/include/grub/misc.h index 7d2b55196..7489685d0 100644 --- a/include/grub/misc.h +++ b/include/grub/misc.h @@ -232,7 +232,8 @@ grub_strncasecmp (const char *s1, const char *s2, grub_size_t n) while (*s1 && *s2 && --n) { - if (grub_tolower (*s1) != grub_tolower (*s2)) + if (grub_tolower ((grub_uint8_t) *s1) + != grub_tolower ((grub_uint8_t) *s2)) break; s1++;