From: Volker Lendecke <vl@samba.org>
Date: Tue, 6 May 2008 13:06:12 +0000 (+0200)
Subject: Fix a memleak in construct_printer_info_7()
X-Git-Tag: samba-4.0.0alpha6~801^2~1497
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=1409ed60e2176e16fdd65b79ca502d9da6f11a74;p=thirdparty%2Fsamba.git

Fix a memleak in construct_printer_info_7()

Also fix a "ignoring asprintf result" warning
(This used to be commit 64d21f39636019d6a17f84efc6fb9e61e67a235e)
---

diff --git a/source3/rpc_server/srv_spoolss_nt.c b/source3/rpc_server/srv_spoolss_nt.c
index a7b477e17d5..0e98a394265 100644
--- a/source3/rpc_server/srv_spoolss_nt.c
+++ b/source3/rpc_server/srv_spoolss_nt.c
@@ -4357,10 +4357,13 @@ static bool construct_printer_info_7(Printer_entry *print_hnd, PRINTER_INFO_7 *p
 	struct GUID guid;
 
 	if (is_printer_published(print_hnd, snum, &guid)) {
-		asprintf(&guid_str, "{%s}",
-			 smb_uuid_string(talloc_tos(), guid));
+		if (asprintf(&guid_str, "{%s}",
+			     smb_uuid_string(talloc_tos(), guid)) == -1) {
+			return false;
+		}
 		strupper_m(guid_str);
 		init_unistr(&printer->guid, guid_str);
+		SAFE_FREE(guid_str);
 		printer->action = SPOOL_DS_PUBLISH;
 	} else {
 		init_unistr(&printer->guid, "");