From: Amos Jeffries <squid3@treenet.co.nz>
Date: Wed, 26 May 2010 03:40:20 +0000 (+1200)
Subject: Author: Alex Rousskov <rousskov@measurement-factory.com>
X-Git-Tag: SQUID_3_1_4~17
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=14cfa4f29eced85a824c1e25a92b28a9365320ac;p=thirdparty%2Fsquid.git

Author: Alex Rousskov <rousskov@measurement-factory.com>
Bug 2922: Fix assertion failed: HttpHeader.cc: "Headers[id].stat.aliveCount"

Fixed header accounting to avoid the "Headers[id].stat.aliveCount" assertion.

We were incrementing the alive header field counter twice for each decrement,
which probably resulted in the alive counter wrapping back to zero, triggering
the assertion.
---

diff --git a/src/HttpHeader.cc b/src/HttpHeader.cc
index fdfefb52fc..f924320b67 100644
--- a/src/HttpHeader.cc
+++ b/src/HttpHeader.cc
@@ -1534,8 +1534,6 @@ HttpHeaderEntry::parse(const char *field_start, const char *field_end)
 
     Headers[id].stat.seenCount++;
 
-    Headers[id].stat.aliveCount++;
-
     debugs(55, 9, "parsed HttpHeaderEntry: '" << name << ": " << value << "'");
 
     return new HttpHeaderEntry(id, name.termedBuf(), value.termedBuf());