From: Alex Waygood <Alex.Waygood@Gmail.com>
Date: Mon, 16 Oct 2023 13:30:35 +0000 (+0100)
Subject: gh-110923: Fix silently skipped tests in test__opcode.py (#110926)
X-Git-Tag: v3.13.0a2~456
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=14d2d1576d9301032a6a1f62caa347ff1685c872;p=thirdparty%2FPython%2Fcpython.git

gh-110923: Fix silently skipped tests in test__opcode.py (#110926)
---

diff --git a/Lib/test/.ruff.toml b/Lib/test/.ruff.toml
index 329a3b4fba6b..ed108550fbf6 100644
--- a/Lib/test/.ruff.toml
+++ b/Lib/test/.ruff.toml
@@ -11,7 +11,6 @@ extend-exclude = [
     "encoded_modules/module_iso_8859_1.py",
     "encoded_modules/module_koi8_r.py",
     # TODO Fix: F811 Redefinition of unused name
-    "test__opcode.py",
     "test_buffer.py",
     "test_ctypes/test_arrays.py",
     "test_ctypes/test_functions.py",
diff --git a/Lib/test/test__opcode.py b/Lib/test/test__opcode.py
index c1f612dc4a63..10f04b64dda4 100644
--- a/Lib/test/test__opcode.py
+++ b/Lib/test/test__opcode.py
@@ -8,6 +8,14 @@ from _opcode import stack_effect
 
 
 class OpListTests(unittest.TestCase):
+    def check_bool_function_result(self, func, ops, expected):
+        for op in ops:
+            if isinstance(op, str):
+                op = dis.opmap[op]
+            with self.subTest(opcode=op, func=func):
+                self.assertIsInstance(func(op), bool)
+                self.assertEqual(func(op), expected)
+
     def test_invalid_opcodes(self):
         invalid = [-100, -1, 255, 512, 513, 1000]
         self.check_bool_function_result(_opcode.is_valid, invalid, False)
@@ -47,7 +55,7 @@ class OpListTests(unittest.TestCase):
         check_function(self, _opcode.has_exc, dis.hasexc)
 
 
-class OpListTests(unittest.TestCase):
+class StackEffectTests(unittest.TestCase):
     def test_stack_effect(self):
         self.assertEqual(stack_effect(dis.opmap['POP_TOP']), -1)
         self.assertEqual(stack_effect(dis.opmap['BUILD_SLICE'], 0), -1)