From: Andreas Gruenbacher <agruenba@redhat.com>
Date: Fri, 18 Apr 2025 14:40:58 +0000 (+0200)
Subject: gfs2: gfs2_create_inode error handling fix
X-Git-Tag: v5.10.239~342
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=15200ea0ffef173239f21bf6c6cf91f372f58bf4;p=thirdparty%2Fkernel%2Fstable.git

gfs2: gfs2_create_inode error handling fix

[ Upstream commit af4044fd0b77e915736527dd83011e46e6415f01 ]

When gfs2_create_inode() finds a directory, make sure to return -EISDIR.

Fixes: 571a4b57975a ("GFS2: bugger off early if O_CREAT open finds a directory")
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---

diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c
index 22905a076a6a2..f266dec205175 100644
--- a/fs/gfs2/inode.c
+++ b/fs/gfs2/inode.c
@@ -636,7 +636,8 @@ static int gfs2_create_inode(struct inode *dir, struct dentry *dentry,
 	if (!IS_ERR(inode)) {
 		if (S_ISDIR(inode->i_mode)) {
 			iput(inode);
-			inode = ERR_PTR(-EISDIR);
+			inode = NULL;
+			error = -EISDIR;
 			goto fail_gunlock;
 		}
 		d_instantiate(dentry, inode);