From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Fri, 10 Oct 2025 14:39:56 +0000 (+0200)
Subject: dnsdist: Properly zero-initialize the "fake" DNS header
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=153a1bf296f58c38cfd4fb96de29e2677ac42e04;p=thirdparty%2Fpdns.git

dnsdist: Properly zero-initialize the "fake" DNS header

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
---

diff --git a/pdns/dnsdistdist/dnsdist.cc b/pdns/dnsdistdist/dnsdist.cc
index 8d6ab47e59..3a3bef3702 100644
--- a/pdns/dnsdistdist/dnsdist.cc
+++ b/pdns/dnsdistdist/dnsdist.cc
@@ -1595,9 +1595,11 @@ bool handleTimeoutResponseRules(const std::vector<dnsdist::rules::ResponseRuleAc
   /* let's be nice and restore the original DNS header as well as we can with what we have */
   PacketBuffer payload(sizeof(dnsheader));
   dnsdist::PacketMangling::editDNSHeaderFromPacket(payload, [&ids](dnsheader& header) {
+    memset(&header, 0, sizeof(header));
     header.id = ids.origID;
-    header.qdcount = htons(1);
     restoreFlags(&header, ids.origFlags);
+    // do not set the qdcount, otherwise the protobuf code will choke on it
+    // while trying to parse the response RRs
     return true;
   });
   DNSResponse dnsResponse(ids, payload, d_ds);