From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Date: Fri, 5 Oct 2018 21:28:56 +0000 (-0700)
Subject: bpo-34899: Fix a possible assertion failure due to int_from_bytes_impl() (GH-9705)
X-Git-Tag: v3.7.1rc2~26
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=1596fea0a329e1f5e4cce0135724881ca5f1d341;p=thirdparty%2FPython%2Fcpython.git

bpo-34899: Fix a possible assertion failure due to int_from_bytes_impl() (GH-9705)


The _PyLong_FromByteArray() call in int_from_bytes_impl() was
unchecked.
(cherry picked from commit 7bb9cd0a6766fd3e7b3c1e8f2315304ae192b34c)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
---

diff --git a/Objects/longobject.c b/Objects/longobject.c
index 269d6cdea590..59c7efbfee2e 100644
--- a/Objects/longobject.c
+++ b/Objects/longobject.c
@@ -5270,7 +5270,7 @@ int_from_bytes_impl(PyTypeObject *type, PyObject *bytes_obj,
         little_endian, is_signed);
     Py_DECREF(bytes);
 
-    if (type != &PyLong_Type) {
+    if (long_obj != NULL && type != &PyLong_Type) {
         Py_SETREF(long_obj, PyObject_CallFunctionObjArgs((PyObject *)type,
                                                          long_obj, NULL));
     }