From: Filipe Brandenburger <filbranden@google.com>
Date: Thu, 7 Jun 2018 21:37:30 +0000 (-0700)
Subject: networkd: add missing _cleanup_ in prefix_new
X-Git-Tag: v239~117
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=15b8332e7cc09b1ae2ef71265cd63bfbc8075eec;p=thirdparty%2Fsystemd.git

networkd: add missing _cleanup_ in prefix_new

This should fix a leak of the allocated Prefix if sd_radv_prefix_new
fails for some reason.

The code was already initializing prefix to NULL and using TAKE_PTR to
return it, so only the _cleanup_ was missing.

Fixes Coverity finding CID 1382976.
---

diff --git a/src/network/networkd-radv.c b/src/network/networkd-radv.c
index 464e636876d..14927b04396 100644
--- a/src/network/networkd-radv.c
+++ b/src/network/networkd-radv.c
@@ -104,7 +104,7 @@ void prefix_free(Prefix *prefix) {
 }
 
 int prefix_new(Prefix **ret) {
-        Prefix *prefix = NULL;
+        _cleanup_(prefix_freep) Prefix *prefix = NULL;
 
         prefix = new0(Prefix, 1);
         if (!prefix)