From: Nick Mathewson <nickm@torproject.org>
Date: Thu, 14 Oct 2021 16:39:05 +0000 (-0400)
Subject: Lower maximum value for guard-extreme-restriction-percent to 100.
X-Git-Tag: tor-0.4.7.2-alpha~27^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=15ede0435f5d161e34c11770b6a96f0f31b6cf2f;p=thirdparty%2Ftor.git

Lower maximum value for guard-extreme-restriction-percent to 100.

Values greater than 100 would have had the same effect as 100, so
this doesn't actually change Tor's behavior; it just makes the
intent clearer.  Fixes #40486; see also torspec#66.
---

diff --git a/changes/bug40486 b/changes/bug40486
new file mode 100644
index 0000000000..83315bfb2b
--- /dev/null
+++ b/changes/bug40486
@@ -0,0 +1,5 @@
+  o Code simplification and refactoring:
+    - Lower the official maximum for "guard-extreme-restriction-percent" to
+      100. This has no effect on when the guard code will generate a warning,
+      but it makes the intent of the option clearer.  Fixes bug 40486; bugfix
+      on 0.3.0.1-alpha.
diff --git a/src/feature/client/entrynodes.c b/src/feature/client/entrynodes.c
index 9583a4db71..315bd54674 100644
--- a/src/feature/client/entrynodes.c
+++ b/src/feature/client/entrynodes.c
@@ -559,7 +559,7 @@ get_extreme_restriction_threshold(void)
   int32_t pct = networkstatus_get_param(NULL,
                                         "guard-extreme-restriction-percent",
                                         DFLT_EXTREME_RESTRICTION_PERCENT,
-                                        1, INT32_MAX);
+                                        1, 100);
   return pct / 100.0;
 }