From: Ondřej Surý <ondrej@isc.org>
Date: Tue, 27 Sep 2022 11:00:09 +0000 (+0200)
Subject: Fix stack-use-after-scope in dns_message_checksig test
X-Git-Tag: v9.19.6~33^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=16377100ae145f2994e6e18f4dfc586403f31ec8;p=thirdparty%2Fbind9.git

Fix stack-use-after-scope in dns_message_checksig test

Previously stack with buffer for test dns message went out of scope
before the message was processed. For fuzz testing its better to avoid
allocation, so let's avoid allocations completely and use simplest
possible static buffer.

Fixes: #3565
---

diff --git a/fuzz/dns_message_checksig.c b/fuzz/dns_message_checksig.c
index 4f248fc2e6c..bead6be9953 100644
--- a/fuzz/dns_message_checksig.c
+++ b/fuzz/dns_message_checksig.c
@@ -213,7 +213,7 @@ create_message(dns_message_t **messagep, const uint8_t *data, size_t size,
 	isc_result_t result;
 	dns_message_t *message = NULL;
 	isc_buffer_t b;
-	unsigned char buf[65535];
+	static unsigned char buf[65535];
 
 	isc_buffer_init(&b, buf, sizeof(buf));