From: Volker Lendecke <vl@samba.org>
Date: Sat, 17 Feb 2018 19:04:23 +0000 (+0100)
Subject: nbt_server: Avoid an "else" branch
X-Git-Tag: ldb-1.3.2~5
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=165570192310e3a51c070bbcc3222664e683887f;p=thirdparty%2Fsamba.git

nbt_server: Avoid an "else" branch

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
---

diff --git a/source4/nbt_server/dgram/netlogon.c b/source4/nbt_server/dgram/netlogon.c
index d37f914fa68..4753ca88a3d 100644
--- a/source4/nbt_server/dgram/netlogon.c
+++ b/source4/nbt_server/dgram/netlogon.c
@@ -114,7 +114,7 @@ static NTSTATUS nbtd_netlogon_samlogon(
 	struct nbt_netlogon_response **presponse)
 {
 	struct ldb_context *samctx;
-	struct dom_sid *sid;
+	struct dom_sid *sid = NULL;
 	struct nbt_netlogon_response *response;
 	NTSTATUS status;
 
@@ -126,10 +126,8 @@ static NTSTATUS nbtd_netlogon_samlogon(
 
 	samctx = nbtsrv->sam_ctx;
 
-	if (netlogon->req.logon.sid_size) {
+	if (netlogon->req.logon.sid_size != 0) {
 		sid = &netlogon->req.logon.sid;
-	} else {
-		sid = NULL;
 	}
 
 	response = talloc_zero(mem_ctx, struct nbt_netlogon_response);