From: Senthil Kumaran Date: Mon, 9 Jul 2012 00:47:25 +0000 (-0700) Subject: revert the changes done for issue14826 - quoting witin Request is not desirable. X-Git-Tag: v3.3.0b2~266^2 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=168456df1158beee5a5051c108a9052a9aebba27;p=thirdparty%2FPython%2Fcpython.git revert the changes done for issue14826 - quoting witin Request is not desirable. --- diff --git a/Lib/test/test_urllib.py b/Lib/test/test_urllib.py index 69d543855e5c..c6f6f6121f37 100644 --- a/Lib/test/test_urllib.py +++ b/Lib/test/test_urllib.py @@ -1246,11 +1246,6 @@ class URLopener_Tests(unittest.TestCase): # ftp.close() - def test_quote_url(self): - Request = urllib.request.Request - request = Request("http://www.python.org/foo bar") - self.assertEqual(request.full_url, "http://www.python.org/foo%20bar") - def test_main(): support.run_unittest( diff --git a/Lib/urllib/request.py b/Lib/urllib/request.py index c77697c57689..d6f9f9a1bcaa 100644 --- a/Lib/urllib/request.py +++ b/Lib/urllib/request.py @@ -181,7 +181,6 @@ class Request: origin_req_host=None, unverifiable=False): # unwrap('') --> 'type://host/path' self.full_url = unwrap(url) - self.full_url = quote(self.full_url, safe="%/:=&?~#+!$,;'@()*[]|") self.full_url, self.fragment = splittag(self.full_url) self.data = data self.headers = {} diff --git a/Misc/NEWS b/Misc/NEWS index 2e2b03fb654b..fe8389755350 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -87,11 +87,6 @@ Core and Builtins Library ------- -- Issue #14826: Quote urls in urllib.request.Request similar to how they are - quoted by urllib.request.URLopener. Allows urls to spaces in them to work - transparently with urllib.request.urlopen(...). Patch contributed by Stephen - Thorne. - - Issue #14990: Correctly fail with SyntaxError on invalid encoding declaration.