From: Alexander Færøy <ahf@torproject.org>
Date: Sat, 23 Jun 2018 01:17:09 +0000 (+0200)
Subject: Fix potential memory leak in test_hs_auth_cookies().
X-Git-Tag: tor-0.2.9.16~9^2^2~3
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=1724f995c71502977c79343922ab50fc2403284f;p=thirdparty%2Ftor.git

Fix potential memory leak in test_hs_auth_cookies().

This patch fixes a potential memory leak in test_hs_auth_cookies() if a
test-case fails and we goto the done label where no memory clean up is
done.

See: Coverity CID 1437453
---

diff --git a/src/test/test_hs.c b/src/test/test_hs.c
index 8237bbc50e..d572dd8d2e 100644
--- a/src/test/test_hs.c
+++ b/src/test/test_hs.c
@@ -446,10 +446,10 @@ test_hs_auth_cookies(void *arg)
 #define TEST_COOKIE_ENCODED_STEALTH "YWJjZGVmZ2hpamtsbW5vcB"
 #define TEST_COOKIE_ENCODED_INVALID "YWJjZGVmZ2hpamtsbW5vcD"
 
-  char *encoded_cookie;
+  char *encoded_cookie = NULL;
   uint8_t raw_cookie[REND_DESC_COOKIE_LEN];
   rend_auth_type_t auth_type;
-  char *err_msg;
+  char *err_msg = NULL;
   int re;
 
   (void)arg;
@@ -495,6 +495,9 @@ test_hs_auth_cookies(void *arg)
   tor_free(err_msg);
 
  done:
+  tor_free(encoded_cookie);
+  tor_free(err_msg);
+
   return;
 }