From: Ethan Furman <ethan@stoneleaf.us>
Date: Wed, 12 Mar 2025 19:10:47 +0000 (-0700)
Subject: gh-131045: [Enum] fix flag containment checks when using values (GH-131053)
X-Git-Tag: v3.14.0a6~51
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=17d06aeb5476099bc1acd89cd6f69e239e0f9350;p=thirdparty%2FPython%2Fcpython.git

gh-131045: [Enum] fix flag containment checks when using values (GH-131053)

Check would fail if value would create a pseudo-member, but that member
had not yet been created.  We now attempt to create a pseudo-member for
a passed-in value first.

Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
---

diff --git a/Lib/enum.py b/Lib/enum.py
index 04443471b40b..ee963d6a7e67 100644
--- a/Lib/enum.py
+++ b/Lib/enum.py
@@ -739,12 +739,14 @@ class EnumType(type):
         `value` is in `cls` if:
         1) `value` is a member of `cls`, or
         2) `value` is the value of one of the `cls`'s members.
+        3) `value` is a pseudo-member (flags)
         """
         if isinstance(value, cls):
             return True
         try:
-            return value in cls._value2member_map_
-        except TypeError:
+            cls(value)
+            return True
+        except ValueError:
             return (
                     value in cls._unhashable_values_    # both structures are lists
                     or value in cls._hashable_values_
diff --git a/Lib/test/test_enum.py b/Lib/test/test_enum.py
index 8884295b1ab8..1a0026987cd7 100644
--- a/Lib/test/test_enum.py
+++ b/Lib/test/test_enum.py
@@ -462,6 +462,7 @@ class _EnumTests:
             self.assertEqual(str(TE), "<flag 'MainEnum'>")
             self.assertEqual(format(TE), "<flag 'MainEnum'>")
             self.assertTrue(TE(5) is self.dupe2)
+            self.assertTrue(7 in TE)
         else:
             self.assertEqual(repr(TE), "<enum 'MainEnum'>")
             self.assertEqual(str(TE), "<enum 'MainEnum'>")
@@ -4954,6 +4955,7 @@ class Color(enum.Enum)
  |      `value` is in `cls` if:
  |      1) `value` is a member of `cls`, or
  |      2) `value` is the value of one of the `cls`'s members.
+ |      3) `value` is a pseudo-member (flags)
  |
  |  __getitem__(name)
  |      Return the member matching `name`.
diff --git a/Misc/NEWS.d/next/Library/2025-03-10-12-26-56.gh-issue-131045.s1TssJ.rst b/Misc/NEWS.d/next/Library/2025-03-10-12-26-56.gh-issue-131045.s1TssJ.rst
new file mode 100644
index 000000000000..b6aa07276bb5
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2025-03-10-12-26-56.gh-issue-131045.s1TssJ.rst
@@ -0,0 +1 @@
+Fix issue with ``__contains__``, values, and pseudo-members for :class:`enum.Flag`.