From: David Seifert <soap@gentoo.org>
Date: Fri, 28 Oct 2022 21:55:07 +0000 (+0200)
Subject: test: remove brittle iszero_safe() test
X-Git-Tag: v252~17
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=17dc285bd4c160c0997b231a9e6099494c1083b2;p=thirdparty%2Fsystemd.git

test: remove brittle iszero_safe() test

The test relies on finite -> infinite conversion happening
when increasing DBL_MAX.

Fixes #25044.
---

diff --git a/src/test/test-math-util.c b/src/test/test-math-util.c
index 0162bf7dc04..9771576fcbb 100644
--- a/src/test/test-math-util.c
+++ b/src/test/test-math-util.c
@@ -54,16 +54,6 @@ TEST(iszero_safe) {
         assert_se( iszero_safe(DBL_MIN / -INFINITY));
         assert_se( iszero_safe(DBL_MAX / INFINITY / 2));
         assert_se( iszero_safe(DBL_MAX / -INFINITY * DBL_MAX));
-#if defined(__i386__) && !defined(__SSE2_MATH__)
-        /* On 32bit x86, -mfpmath=387 is the default and SSE2 is not used. Then, floating point values are
-         * calculated in 80bit, and truncated to the length of the used type (double in this case). Hence,
-         * DBL_MAX * 2 is temporary calculated as a normal value, and goes to zero when divided with
-         * INFINITY. See issue #25044. */
-        log_debug("i386 architecture without SSE2 is detected. "
-                  "Skipping \"assert_se(!iszero_safe(DBL_MAX * 2 / INFINITY))\".");
-#else
-        assert_se(!iszero_safe(DBL_MAX * 2 / INFINITY));
-#endif
 
         /* infinity / infinity is NaN */
         assert_se(!iszero_safe(INFINITY / INFINITY));