From: Gaurav <g.gupta@samsung.com>
Date: Fri, 4 Dec 2020 11:15:15 +0000 (+0530)
Subject: Detect special character in dbus interface name
X-Git-Tag: v248-rc1~506
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=17f8a21fd069d7a3269496a59911c3b20fa1b324;p=thirdparty%2Fsystemd.git

Detect special character in dbus interface name

Added debug log to detect special character in dbus interface names.
Helps to detect a case mentioned in https://github.com/systemd/systemd/issues/14636
---

diff --git a/src/libsystemd/sd-bus/bus-internal.c b/src/libsystemd/sd-bus/bus-internal.c
index 3f03ad7c411..c66056dcc4c 100644
--- a/src/libsystemd/sd-bus/bus-internal.c
+++ b/src/libsystemd/sd-bus/bus-internal.c
@@ -91,8 +91,10 @@ bool interface_name_is_valid(const char *p) {
                                 (!dot && *q >= '0' && *q <= '9') ||
                                 *q == '_';
 
-                        if (!good)
+                        if (!good) {
+                                log_debug("The interface %s is invalid as it contains special character %c", p, *q);
                                 return false;
+                        }
 
                         dot = false;
                 }