From: Nick Mathewson <nickm@torproject.org>
Date: Sat, 19 Apr 2014 16:50:17 +0000 (-0400)
Subject: scan-build: Fix harmless sizeof(ptr) in test_oom.c
X-Git-Tag: tor-0.2.5.4-alpha~14^2~4
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=1800e79ca508e555d43eb8ca36e9544f42c98944;p=thirdparty%2Ftor.git

scan-build: Fix harmless sizeof(ptr) in test_oom.c

We meant to using random bytes to fill a buffer, up to 3000 at a
time. Instead we were taking them sizeof(void*) at a time.
---

diff --git a/src/test/test_oom.c b/src/test/test_oom.c
index cc6e532358..989ca1203b 100644
--- a/src/test/test_oom.c
+++ b/src/test/test_oom.c
@@ -82,8 +82,8 @@ add_bytes_to_buf(generic_buffer_t *buf, size_t n_bytes)
   char b[3000];
 
   while (n_bytes) {
-    size_t this_add = n_bytes > sizeof(buf) ? sizeof(buf) : n_bytes;
-    crypto_rand(b, sizeof(b));
+    size_t this_add = n_bytes > sizeof(b) ? sizeof(b) : n_bytes;
+    crypto_rand(b, this_add);
     generic_buffer_add(buf, b, this_add);
     n_bytes -= this_add;
   }