From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Date: Tue, 14 Nov 2017 07:01:29 +0000 (-0800)
Subject: bpo-32020: arraymodule: Correct missing Py_DECREF in failure case of make_array(... 
X-Git-Tag: v3.6.4rc1~72
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=18056fb11e6fe6e5247cd03073bd74df8ac0acc7;p=thirdparty%2FPython%2Fcpython.git

bpo-32020: arraymodule: Correct missing Py_DECREF in failure case of make_array() (GH-4391) (#4392)

(cherry picked from commit 56935a53b11b9a70f3e13e460777ec81a5b9195e)
---

diff --git a/Modules/arraymodule.c b/Modules/arraymodule.c
index 64e0f172fd7d..9254af59a6a2 100644
--- a/Modules/arraymodule.c
+++ b/Modules/arraymodule.c
@@ -1885,8 +1885,10 @@ make_array(PyTypeObject *arraytype, char typecode, PyObject *items)
         return NULL;
 
     new_args = PyTuple_New(2);
-    if (new_args == NULL)
+    if (new_args == NULL) {
+        Py_DECREF(typecode_obj);
         return NULL;
+    }
     Py_INCREF(items);
     PyTuple_SET_ITEM(new_args, 0, typecode_obj);
     PyTuple_SET_ITEM(new_args, 1, items);