From: Christian Göttsche <cgzones@googlemail.com>
Date: Mon, 13 Jun 2022 14:01:04 +0000 (+0200)
Subject: sysctl: increase log severity on failed write
X-Git-Tag: v252-rc1~812
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=1805fbcf064c35b13186f1f4ae6590a5cffe59f1;p=thirdparty%2Fsystemd.git

sysctl: increase log severity on failed write

Increase the log severity in case of writing to a non existent sysctl
parameter as this can either be caused by a misspelling or a kernel mis-
configuration, e.g. in case YAMA does not get loaded due to a incomplete
lsm= override:

    systemd-sysctl[354]: Couldn't write '1' to 'kernel/yama/ptrace_scope', ignoring: No such file or directory
---

diff --git a/src/sysctl/sysctl.c b/src/sysctl/sysctl.c
index 24c8baab03f..2b854a73709 100644
--- a/src/sysctl/sysctl.c
+++ b/src/sysctl/sysctl.c
@@ -107,7 +107,7 @@ static int sysctl_write_or_warn(const char *key, const char *value, bool ignore_
                 if (ignore_failure || r == -EROFS || ERRNO_IS_PRIVILEGE(r))
                         log_debug_errno(r, "Couldn't write '%s' to '%s', ignoring: %m", value, key);
                 else if (r == -ENOENT)
-                        log_info_errno(r, "Couldn't write '%s' to '%s', ignoring: %m", value, key);
+                        log_warning_errno(r, "Couldn't write '%s' to '%s', ignoring: %m", value, key);
                 else
                         return log_error_errno(r, "Couldn't write '%s' to '%s': %m", value, key);
         }