From: Noel Power <noel.power@suse.com>
Date: Tue, 10 Dec 2019 16:10:20 +0000 (+0000)
Subject: selftest: Don't skip smb1 tests and remove associate skip file
X-Git-Tag: ldb-2.2.0~1010
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=182635bb78b17d4b93129d708337312477ed34ad;p=thirdparty%2Fsamba.git

selftest: Don't skip smb1 tests and remove associate skip file

remove the skip file and the code to use it from the build as
all tests now run in either specific smb1 enabled envs or normal
(non smb1) envs

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Ralph Boehme <slow@samba.org>
---

diff --git a/selftest/skip_smb1_fails b/selftest/skip_smb1_fails
deleted file mode 100644
index 6d6d23a0782..00000000000
--- a/selftest/skip_smb1_fails
+++ /dev/null
@@ -1,8 +0,0 @@
-# This file contains a list of regular expressions matching testsuites that
-# should be skipped during "make test".
-# These testsuites are failing with min protocol set to SMB2_02 indicating
-# that these tests are SMB1 only or have some SMB1 dependency \(or fail\) for
-# so other odd reason. We need to either
-# a) remove the failing test
-# b) port the failing test to SMB2
-# c) fix the test
diff --git a/selftest/wscript b/selftest/wscript
index 4bb4ead2a35..57057be176e 100644
--- a/selftest/wscript
+++ b/selftest/wscript
@@ -182,9 +182,6 @@ def cmd_testonly(opt):
     else:
         env.FILTER_OPTIONS = '${FILTER_XFAIL}'
 
-    # Maybe this should be optional
-    env.OPTIONS += ' --exclude=${srcdir}/selftest/skip_smb1_fails'
-
     if Options.options.VALGRIND:
         os.environ['VALGRIND'] = 'valgrind -q --num-callers=30'
         if Options.options.VALGRINDLOG is not None: