From: Stefan Metzmacher <metze@samba.org>
Date: Tue, 30 Jan 2018 11:19:31 +0000 (+0100)
Subject: dbcheck: make sure we ask for replPropertyMetaData if we need to process any forward... 
X-Git-Tag: tevent-0.9.36~229
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=182fb3c4c9db8715d0dbcbc3d1aa0655b5cb29f1;p=thirdparty%2Fsamba.git

dbcheck: make sure we ask for replPropertyMetaData if we need to process any forward link attributes

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13228

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
---

diff --git a/python/samba/dbchecker.py b/python/samba/dbchecker.py
index 5ae57e29b8d..5b9c5515a06 100644
--- a/python/samba/dbchecker.py
+++ b/python/samba/dbchecker.py
@@ -1811,7 +1811,19 @@ newSuperior: %s""" % (str(from_dn), str(to_rdn), str(to_base)))
             attrs.append(dn.get_rdn_name())
             attrs.append("isDeleted")
             attrs.append("systemFlags")
+        need_replPropertyMetaData = False
         if '*' in attrs:
+            need_replPropertyMetaData = True
+        else:
+            for a in attrs:
+                linkID, _ = self.get_attr_linkID_and_reverse_name(a)
+                if linkID == 0:
+                    continue
+                if linkID & 1:
+                    continue
+                need_replPropertyMetaData = True
+                break
+        if need_replPropertyMetaData:
             attrs.append("replPropertyMetaData")
         attrs.append("objectGUID")