From: Evan Hunt <each@isc.org>
Date: Mon, 3 Apr 2023 17:43:32 +0000 (-0700)
Subject: address coverity warnings in delv
X-Git-Tag: v9.19.12~7^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=1850daaed8303977e7827a9788ade830801b5fcf;p=thirdparty%2Fbind9.git

address coverity warnings in delv

clean up coverity warnings due to recent changes to delv:
- CID 451097: failure to check return value from inet_pton()
- CID 451098, 451100: dead code
---

diff --git a/bin/delv/delv.c b/bin/delv/delv.c
index 91ebe623481..8d68782d101 100644
--- a/bin/delv/delv.c
+++ b/bin/delv/delv.c
@@ -2088,12 +2088,6 @@ sendquery(void *arg) {
 
 cleanup:
 	if (message != NULL) {
-		if (mname != NULL) {
-			dns_message_puttempname(message, &mname);
-		}
-		if (mrdataset != NULL) {
-			dns_message_puttemprdataset(message, &mrdataset);
-		}
 		dns_message_detach(&message);
 	}
 
@@ -2123,7 +2117,7 @@ run_server(void *arg) {
 
 	UNUSED(arg);
 
-	inet_pton(AF_INET, "127.0.0.1", &in);
+	RUNTIME_CHECK(inet_pton(AF_INET, "127.0.0.1", &in));
 	isc_sockaddr_fromin(&addr, &in, 0);
 
 	CHECK(ns_server_create(mctx, matchview, &sctx));