From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> Date: Sun, 10 Aug 2025 13:55:29 +0000 (+0200) Subject: [3.14] gh-131338: Disable computed stack limit checks on non-glibc linux (GH-134336... X-Git-Tag: v3.14.0rc2~17 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=1878fe814a13cd620feff17ebcac774a2925d445;p=thirdparty%2FPython%2Fcpython.git [3.14] gh-131338: Disable computed stack limit checks on non-glibc linux (GH-134336) (#137175) Co-authored-by: R. David Murray Co-authored-by: Kumar Aditya Co-authored-by: Victor Stinner --- diff --git a/Misc/NEWS.d/next/Core_and_Builtins/2025-07-25-22-31-52.gh-issue-131338.zJDCMp.rst b/Misc/NEWS.d/next/Core_and_Builtins/2025-07-25-22-31-52.gh-issue-131338.zJDCMp.rst new file mode 100644 index 000000000000..6c064e8f4a03 --- /dev/null +++ b/Misc/NEWS.d/next/Core_and_Builtins/2025-07-25-22-31-52.gh-issue-131338.zJDCMp.rst @@ -0,0 +1,2 @@ +Disable computed stack limit checks on non-glibc linux platforms to fix +crashes on deep recursion. diff --git a/Python/ceval.c b/Python/ceval.c index 42080f77f2a0..e5b1b82e45e1 100644 --- a/Python/ceval.c +++ b/Python/ceval.c @@ -439,7 +439,11 @@ _Py_InitializeRecursionLimits(PyThreadState *tstate) _tstate->c_stack_soft_limit = _tstate->c_stack_hard_limit + _PyOS_STACK_MARGIN_BYTES; #else uintptr_t here_addr = _Py_get_machine_stack_pointer(); -# if defined(HAVE_PTHREAD_GETATTR_NP) && !defined(_AIX) && !defined(__NetBSD__) +/// XXX musl supports HAVE_PTHRED_GETATTR_NP, but the resulting stack size +/// (on alpine at least) is much smaller than expected and imposes undue limits +/// compared to the old stack size estimation. (We assume musl is not glibc.) +# if defined(HAVE_PTHREAD_GETATTR_NP) && !defined(_AIX) && \ + !defined(__NetBSD__) && (defined(__GLIBC__) || !defined(__linux__)) size_t stack_size, guard_size; void *stack_addr; pthread_attr_t attr;