From: Ralph Boehme Date: Mon, 30 Oct 2023 18:04:56 +0000 (+0100) Subject: smbd: remove call to fdos_mode() when setting DOS attrs X-Git-Tag: talloc-2.4.2~854 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=19434fe06d14a7fc2c9089cc880c93257eda5518;p=thirdparty%2Fsamba.git smbd: remove call to fdos_mode() when setting DOS attrs This added in 49a754b82d33fb523cda4151a865584ae52a2e2f to work with stored itime based File-Ids. Since switching back to purely inode based File-Ids we can remove this call that primed itime from DOS xattr. Signed-off-by: Ralph Boehme Reviewed-by: Jeremy Allison --- diff --git a/source3/smbd/open.c b/source3/smbd/open.c index 9e5bf2f6731..b99692f34ed 100644 --- a/source3/smbd/open.c +++ b/source3/smbd/open.c @@ -4414,7 +4414,6 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn, /* Overwritten files should be initially set as archive */ if ((info == FILE_WAS_OVERWRITTEN && lp_map_archive(SNUM(conn))) || lp_store_dos_attributes(SNUM(conn))) { - (void)fdos_mode(fsp); if (!posix_open) { if (file_set_dosmode(conn, smb_fname, new_dos_attributes | FILE_ATTRIBUTE_ARCHIVE,