From: Daan De Meyer <daan.j.demeyer@gmail.com>
Date: Mon, 13 Oct 2025 08:43:16 +0000 (+0200)
Subject: sd-id128: Drop _sd_const_ from sd_id128_in_setv()
X-Git-Tag: v257.10~2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=1953f0f25fdd4652b4ab2ee523ee088c1801528f;p=thirdparty%2Fsystemd.git

sd-id128: Drop _sd_const_ from sd_id128_in_setv()

Both the const and pure attributes disallow modifying input arguments
but sd_id128_in_setv() clearly modifies its ap input argument by iterating
over it with va_arg() so drop the _sd_const_ attribute from
sd_id128_in_setv().

(cherry picked from commit 675fa49f69943b0f009c973ed3d1e90afc1d88b1)
(cherry picked from commit 89950fc6a731e43dcb825ef06ad2f3f566ed7c3e)
---

diff --git a/src/systemd/sd-id128.h b/src/systemd/sd-id128.h
index 7be690400d1..9be3f19e813 100644
--- a/src/systemd/sd-id128.h
+++ b/src/systemd/sd-id128.h
@@ -134,7 +134,7 @@ _sd_const_ static __inline__ int sd_id128_is_allf(sd_id128_t a) {
 #define SD_ID128_NULL ((const sd_id128_t) { .qwords = { 0, 0 }})
 #define SD_ID128_ALLF ((const sd_id128_t) { .qwords = { UINT64_C(0xFFFFFFFFFFFFFFFF), UINT64_C(0xFFFFFFFFFFFFFFFF) }})
 
-_sd_const_ static __inline__ int sd_id128_in_setv(sd_id128_t a, va_list ap) {
+static __inline__ int sd_id128_in_setv(sd_id128_t a, va_list ap) {
         for (;;) {
                 sd_id128_t b = va_arg(ap, sd_id128_t);