From: JINMEI Tatuya Date: Wed, 25 Jan 2012 20:12:22 +0000 (-0800) Subject: [1611] revised some test cases for result flags: do exact match rather than X-Git-Tag: trac2351_base~278^2~3^2~1^2 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=196eb4d56de69eaec1bb87ea0c086db4e19d1eba;p=thirdparty%2Fkea.git [1611] revised some test cases for result flags: do exact match rather than testing a single flag. it's stricter and probably a better test. --- diff --git a/src/lib/python/isc/datasrc/tests/datasrc_test.py b/src/lib/python/isc/datasrc/tests/datasrc_test.py index 5ccd18e40e..a6f8f1639b 100644 --- a/src/lib/python/isc/datasrc/tests/datasrc_test.py +++ b/src/lib/python/isc/datasrc/tests/datasrc_test.py @@ -403,7 +403,7 @@ class DataSrcClient(unittest.TestCase): finder.find(isc.dns.Name("foo.wild.example.com"), isc.dns.RRType.A(), finder.FIND_DEFAULT) self.assertEqual(finder.SUCCESS, result) - self.assertTrue((flags & finder.RESULT_WILDCARD) != 0) + self.assertEqual(finder.RESULT_WILDCARD, flags) self.assertEqual("foo.wild.example.com. 3600 IN A 192.0.2.255\n", rrset.to_text()) @@ -411,7 +411,7 @@ class DataSrcClient(unittest.TestCase): isc.dns.RRType.TXT(), finder.FIND_DEFAULT) self.assertEqual(finder.NXRRSET, result) - self.assertTrue((flags & finder.RESULT_WILDCARD) != 0) + self.assertTrue(finder.RESULT_WILDCARD, flags) self.assertEqual(None, rrset) self.assertRaises(TypeError, finder.find,