From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Date: Thu, 11 Oct 2018 05:28:08 +0000 (-0700)
Subject: Fix a possible decref of a borrowed reference in symtable.c. (GH-9786)
X-Git-Tag: v3.6.7rc2~3
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=1a23abed1340c44e0296d9963487443f63aea225;p=thirdparty%2FPython%2Fcpython.git

Fix a possible decref of a borrowed reference in symtable.c. (GH-9786)

(cherry picked from commit fc439d20de32b0ebccca79a96e31f83b85ec4eaf)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
---

diff --git a/Python/symtable.c b/Python/symtable.c
index 6165cfe162ea..90b07efa0334 100644
--- a/Python/symtable.c
+++ b/Python/symtable.c
@@ -628,8 +628,10 @@ update_symbols(PyObject *symbols, PyObject *scopes,
         return 0;
 
     itr = PyObject_GetIter(free);
-    if (!itr)
-        goto error;
+    if (itr == NULL) {
+        Py_DECREF(v_free);
+        return 0;
+    }
 
     while ((name = PyIter_Next(itr))) {
         v = PyDict_GetItem(symbols, name);