From: Tobias Brunner <tobias@strongswan.org>
Date: Thu, 6 Jul 2017 13:40:42 +0000 (+0200)
Subject: android: Catch NullPointerException when parsing invalid certificates
X-Git-Tag: 5.6.1dr2~10^2~9
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=1a9261a923e72f4f223b7e00c980df19c5a1f417;p=thirdparty%2Fstrongswan.git

android: Catch NullPointerException when parsing invalid certificates
---

diff --git a/src/frontends/android/app/src/main/java/org/strongswan/android/security/TrustedCertificateEntry.java b/src/frontends/android/app/src/main/java/org/strongswan/android/security/TrustedCertificateEntry.java
index 5e9873d1bd..4a1dc8e5fa 100644
--- a/src/frontends/android/app/src/main/java/org/strongswan/android/security/TrustedCertificateEntry.java
+++ b/src/frontends/android/app/src/main/java/org/strongswan/android/security/TrustedCertificateEntry.java
@@ -43,29 +43,38 @@ public class TrustedCertificateEntry implements Comparable<TrustedCertificateEnt
 		mCert = cert;
 		mAlias = alias;
 
-		SslCertificate ssl = new SslCertificate(mCert);
-		String o = ssl.getIssuedTo().getOName();
-		String ou = ssl.getIssuedTo().getUName();
-		String cn = ssl.getIssuedTo().getCName();
-		if (!o.isEmpty())
+		try
 		{
-			mSubjectPrimary = o;
-			if (!cn.isEmpty())
+			SslCertificate ssl = new SslCertificate(mCert);
+			String o = ssl.getIssuedTo().getOName();
+			String ou = ssl.getIssuedTo().getUName();
+			String cn = ssl.getIssuedTo().getCName();
+			if (!o.isEmpty())
 			{
-				mSubjectSecondary = cn;
+				mSubjectPrimary = o;
+				if (!cn.isEmpty())
+				{
+					mSubjectSecondary = cn;
+				}
+				else if (!ou.isEmpty())
+				{
+					mSubjectSecondary = ou;
+				}
 			}
-			else if (!ou.isEmpty())
+			else if (!cn.isEmpty())
 			{
-				mSubjectSecondary = ou;
+				mSubjectPrimary = cn;
+			}
+			else
+			{
+				mSubjectPrimary = ssl.getIssuedTo().getDName();
 			}
 		}
-		else if (!cn.isEmpty())
-		{
-			mSubjectPrimary = cn;
-		}
-		else
+		catch (NullPointerException ex)
 		{
-			mSubjectPrimary = ssl.getIssuedTo().getDName();
+			/* this has been seen in Play Console for certificates for which notBefore apparently
+			 * can't be parsed (which SslCertificate() does) */
+			mSubjectPrimary = cert.getSubjectDN().getName();
 		}
 	}