From: Nick Mathewson <nickm@torproject.org>
Date: Tue, 17 Apr 2018 23:41:51 +0000 (-0400)
Subject: Add an initialization case to node_get_prim_dirport
X-Git-Tag: tor-0.3.4.1-alpha~137
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=1abe0a5769f3fe7c2a36975acd8ab1e861925f51;p=thirdparty%2Ftor.git

Add an initialization case to node_get_prim_dirport

Fixes a bug found by scan-build; bugfix on c2fa743806acc. Bug not in
any released Tor.
---

diff --git a/src/or/nodelist.c b/src/or/nodelist.c
index 81a5c944ac..bbcfb6cfff 100644
--- a/src/or/nodelist.c
+++ b/src/or/nodelist.c
@@ -1583,6 +1583,11 @@ node_get_prim_dirport(const node_t *node, tor_addr_port_t *ap_out)
   node_assert_ok(node);
   tor_assert(ap_out);
 
+  /* Clear the address, as a safety precaution if calling functions ignore the
+   * return value */
+  tor_addr_make_null(&ap_out->addr, AF_INET);
+  ap_out->port = 0;
+
   /* Check ri first, because rewrite_node_address_for_bridge() updates
    * node->ri with the configured bridge address. */