From: Michal 'vorner' Vaner <michal.vaner@nic.cz>
Date: Wed, 18 Jul 2012 14:47:38 +0000 (+0200)
Subject: [2123] Small performance improvements in tests
X-Git-Tag: trac2351_base~112^2~55
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=1ad06f822c6e18d16f88809cfcd3f7ea0ce42f6b;p=thirdparty%2Fkea.git

[2123] Small performance improvements in tests

As suggested by cppcheck.
---

diff --git a/src/lib/log/tests/logger_name_unittest.cc b/src/lib/log/tests/logger_name_unittest.cc
index 51fead57c1..39f5ed1f25 100644
--- a/src/lib/log/tests/logger_name_unittest.cc
+++ b/src/lib/log/tests/logger_name_unittest.cc
@@ -31,9 +31,9 @@ using namespace isc::log;
 
 class LoggerNameTest : public ::testing::Test {
 public:
-    LoggerNameTest() {
-        name_ = getRootLoggerName();
-    }
+    LoggerNameTest() :
+        name_(getRootLoggerName())
+    {}
     ~LoggerNameTest() {
         setRootLoggerName(name_);
     }
diff --git a/src/lib/server_common/tests/socket_requestor_test.cc b/src/lib/server_common/tests/socket_requestor_test.cc
index 9adf84d076..9878c632be 100644
--- a/src/lib/server_common/tests/socket_requestor_test.cc
+++ b/src/lib/server_common/tests/socket_requestor_test.cc
@@ -450,7 +450,7 @@ private:
     // NOTE: client_fd could leak on exception.  This should be cleaned up.
     // See the note about SocketSessionReceiver in socket_request.cc.
     void
-    serve(const std::vector<std::pair<std::string, int> > data) {
+    serve(const std::vector<std::pair<std::string, int> >& data) {
         const int client_fd = accept(fd_, NULL, NULL);
         if (client_fd == -1) {
             isc_throw(Unexpected, "Error in accept(): " << strerror(errno));