From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Thu, 5 Oct 2023 22:16:37 +0000 (+1300)
Subject: s4:dns_server: Check return value of ldb_transaction_commit() (CID 1034631)
X-Git-Tag: tevent-0.16.0~53
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=1ad4dd92882b5e299b02d981386c6ec9d60ee5cb;p=thirdparty%2Fsamba.git

s4:dns_server: Check return value of ldb_transaction_commit() (CID 1034631)

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/source4/dns_server/dns_update.c b/source4/dns_server/dns_update.c
index 13f16f244f8..4d2ee0bac71 100644
--- a/source4/dns_server/dns_update.c
+++ b/source4/dns_server/dns_update.c
@@ -753,7 +753,10 @@ static WERROR handle_updates(struct dns_server *dns,
 
 failed:
 	if (W_ERROR_IS_OK(werror)) {
-		ldb_transaction_commit(dns->samdb);
+		ret = ldb_transaction_commit(dns->samdb);
+		if (ret != LDB_SUCCESS) {
+			werror = DNS_ERR(SERVER_FAILURE);
+		}
 	} else {
 		ldb_transaction_cancel(dns->samdb);
 	}