From: Sam Gross <colesbury@gmail.com>
Date: Thu, 11 Apr 2024 21:35:46 +0000 (-0400)
Subject: gh-117649: Fix file descriptor leak in (expected) failing test case (#117780)
X-Git-Tag: v3.13.0b1~474
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=1b10efad66e9a0b72aae82de23074eafa49ec4db;p=thirdparty%2FPython%2Fcpython.git

gh-117649: Fix file descriptor leak in (expected) failing test case (#117780)

The test case is currently expected to fail in the free-threaded build.
However, it fails before it gets a chance to close the write end of
the pipe.
---

diff --git a/Lib/test/test_capi/test_misc.py b/Lib/test/test_capi/test_misc.py
index 8cdecaf36264..9c24ec8fd05b 100644
--- a/Lib/test/test_capi/test_misc.py
+++ b/Lib/test/test_capi/test_misc.py
@@ -2139,6 +2139,9 @@ class SubinterpreterTest(unittest.TestCase):
             }
 
             r, w = os.pipe()
+            if Py_GIL_DISABLED:
+                # gh-117649: The test fails before `w` is closed
+                self.addCleanup(os.close, w)
             script = textwrap.dedent(f'''
                 from test.test_capi.check_config import run_singlephase_check
                 run_singlephase_check({override}, {w})